Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1447 user-login-migration refactorings #4556

Merged
merged 6 commits into from
Nov 14, 2023
Merged

N21-1447 user-login-migration refactorings #4556

merged 6 commits into from
Nov 14, 2023

Conversation

arnegns
Copy link
Contributor

@arnegns arnegns commented Nov 14, 2023 •
edited
Loading

Description

Refactors user-login-migration things from dp review

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1447

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

MarvinOehlerkingCap
MarvinOehlerkingCap requested changes Nov 14, 2023
View reviewed changes
apps/server/src/modules/user-login-migration/service/migration-check.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/user-login-migration/service/migration-check.service.ts Outdated Show resolved Hide resolved
.../server/src/modules/user-login-migration/loggable/user-login-migration-mandatory.loggable.ts Outdated Show resolved Hide resolved
...r/src/modules/user-login-migration/loggable/user-login-migration-start-loggable-exception.ts Outdated Show resolved Hide resolved
apps/server/src/modules/user-login-migration/loggable/index.ts Outdated Show resolved Hide resolved
apps/server/src/modules/user-login-migration/service/migration-check.service.ts Show resolved Hide resolved
apps/server/src/modules/user-login-migration/service/user-login-migration.service.ts Outdated Show resolved Hide resolved
apps/server/src/modules/user-login-migration/uc/toggle-user-login-migration.uc.spec.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit b3b4cee into main Nov 14, 2023
46 of 47 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-1447-user-login-migration-refactoring-2 branch November 14, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnegns @MarvinOehlerkingCap